Kobi Ianko has posted comments on this change.

Change subject: db, core: aggregate qos and storage qos impl
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/27094/8/packaging/dbscripts/qos_sp.sql
File packaging/dbscripts/qos_sp.sql:

Line 30:   v_max_read_throughput INTEGER,
Line 31:   v_max_write_throughput INTEGER,
Line 32:   v_max_iops INTEGER,
Line 33:   v_max_read_iops INTEGER,
Line 34:   v_max_write_iops INTEGER)
once you are done I will need to add my param to all the functions, and change 
your engine code to pass null at my param
Line 35: RETURNS VOID
Line 36:    AS $procedure$
Line 37: BEGIN
Line 38:       UPDATE qos


-- 
To view, visit http://gerrit.ovirt.org/27094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to