Yair Zaslavsky has posted comments on this change.

Change subject: core: add permission for changing custom properties
......................................................................


Patch Set 1:

I see some repetitiveness at code.
Can you somehow please extract this to a method in a base class or Helper class 
that will be used across the commands?
Besides that the code looks good.

--
To view, visit http://gerrit.ovirt.org/5492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7409927233901439e33ec31c1091dd5948953e7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to