Gilad Chaplik has posted comments on this change. Change subject: core: Add CRUD commands and queries for QoS objects (storage) ......................................................................
Patch Set 8: (4 comments) forgot to upload it... THANKS MOTI & LIRON!!! http://gerrit.ovirt.org/#/c/27096/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageQosValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageQosValidator.java: Line 25: * write value. Line 26: */ Line 27: @Override Line 28: public ValidationResult allValuesPresent() { Line 29: return missingCategoryValues(getQos().getMaxThroughput(), > this seems like too complex condition to be inlined. Done Line 30: getQos().getMaxReadThroughput(), Line 31: getQos().getMaxWriteThroughput()) Line 32: || missingCategoryValues(getQos().getMaxIops(), Line 33: getQos().getMaxReadIops(), Line 37: } Line 38: Line 39: private boolean missingCategoryValues(Integer total, Integer read, Integer write) { Line 40: return (isPositive(total) && !isPositive(read) && !isPositive(write)) Line 41: || (!isPositive(total) && isPositive(read) && isPositive(write)); changed here a bit.... 10x Moti. Line 42: } Line 43: Line 44: private boolean isPositive(Integer value) { Line 45: if (value == null || value <= 0) { Line 42: } Line 43: Line 44: private boolean isPositive(Integer value) { Line 45: if (value == null || value <= 0) { Line 46: return true; > seems like the opposite response. was coded late, thanks! Done. Line 47: } Line 48: return false; Line 49: } http://gerrit.ovirt.org/#/c/27096/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 974: USER_UPDATED_NETWORK_QOS(10104), Line 975: USER_FAILED_TO_UPDATE_NETWORK_QOS(10105, AuditLogSeverity.ERROR), Line 976: Line 977: // Qos Line 978: USER_ADDED_QOS(10100), > the ids should be unique within this file. went with the ctrl+c-ctrl+v too far.. LOL Done. Line 979: USER_FAILED_TO_ADD_QOS(10101, AuditLogSeverity.ERROR), Line 980: USER_REMOVED_QOS(10102), Line 981: USER_FAILED_TO_REMOVE_QOS(10103, AuditLogSeverity.ERROR), Line 982: USER_UPDATED_QOS(10104), -- To view, visit http://gerrit.ovirt.org/27096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c00522ddb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
