Yaniv Kaul has posted comments on this change.

Change subject: core: fix canDoAction message variable format
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Please rephrase these -> the

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 169: ACTION_TYPE_FAILED_INVALID_CUSTOM_VM_PROPERTIES_INVALID_KEYS=Cannot 
${action} ${type} if some of the specified custom properties are not configured 
by the system. These keys are: ${MissingKeys}
These ->  the
or
These -> Those (I prefer the first option).
As is, it sounds wrong.

--
To view, visit http://gerrit.ovirt.org/5476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I228b25a7ff4dac9ad690c47160d033eabd3e0df6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to