Daniel Erez has posted comments on this change. Change subject: webadmin: import entities from data SDs - sub-tabs ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/28604/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterTemplateListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterTemplateListModel.java: Line 23: setHashName("template_register"); //$NON-NLS-1$ Line 24: } Line 25: Line 26: @Override Line 27: protected void syncSearch() { > Can't say I really like it, there's too much in common between the syncSear I'll work on with in a following patch... Line 28: if (getEntity() == null) { Line 29: return; Line 30: } Line 31: http://gerrit.ovirt.org/#/c/28604/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterTemplateView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterTemplateView.java: Line 70: } Line 71: }; Line 72: getTable().addColumn(archColumn, constants.architectureVm(), "100px"); //$NON-NLS-1$ Line 73: Line 74: TextColumnWithTooltip<VmTemplate> diskColumn = new TextColumnWithTooltip<VmTemplate>() { > Perhaps a better name will be numOfDisksColumn? Done Line 75: @Override Line 76: public String getValue(VmTemplate object) { Line 77: return String.valueOf(object.getDiskTemplateMap().size()); Line 78: } http://gerrit.ovirt.org/#/c/28604/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterVmView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterVmView.java: Line 70: } Line 71: }; Line 72: getTable().addColumn(archColumn, constants.architectureVm(), "100px"); //$NON-NLS-1$ Line 73: Line 74: TextColumnWithTooltip<VM> diskColumn = new TextColumnWithTooltip<VM>() { > Perhaps a better name will be numOfDisksColumn? Done Line 75: @Override Line 76: public String getValue(VM object) { Line 77: return String.valueOf(object.getDiskMap().size()); Line 78: } -- To view, visit http://gerrit.ovirt.org/28604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f0a6af44c4e066cf4e0b876331f7c8ce78b79c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
