Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Implement sorting for network roles column
......................................................................

webadmin: Implement sorting for network roles column

Implemented logic to compare between network roles in the
Network/Clusters subtab.

Change-Id: Icd9fa5bfee38e9b46f94708f5b4d88240261b404
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/28754/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
index 30d591c..fcb0cb4 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
@@ -1,5 +1,6 @@
 package org.ovirt.engine.ui.webadmin.section.main.view.tab.network;
 
+import java.util.Comparator;
 import java.util.LinkedHashMap;
 import java.util.LinkedList;
 import java.util.List;
@@ -154,7 +155,26 @@
                         return 
NetworkRoleColumnHelper.getTooltip(imagesToText);
                     }
                 };
+        netRoleColumn.makeSortable(new Comparator<PairQueryable<VDSGroup, 
NetworkCluster>>() {
 
+            private int calculateValue(NetworkCluster networkCluster) {
+                int res = 0;
+                if (networkCluster != null) {
+                    if (networkCluster.isDisplay()) {
+                        res += 2;
+                    }
+                    if (networkCluster.isMigration()) {
+                        res += 1;
+                    }
+                }
+                return res;
+            }
+
+            @Override
+            public int compare(PairQueryable<VDSGroup, NetworkCluster> o1, 
PairQueryable<VDSGroup, NetworkCluster> o2) {
+                return calculateValue(o1.getSecond()) - 
calculateValue(o2.getSecond());
+            }
+        });
         getTable().addColumn(netRoleColumn, constants.roleNetCluster(), 
"120px"); //$NON-NLS-1$
 
         TextColumnWithTooltip<PairQueryable<VDSGroup, NetworkCluster>> 
descriptionColumn = new TextColumnWithTooltip<PairQueryable<VDSGroup, 
NetworkCluster>>() {


-- 
To view, visit http://gerrit.ovirt.org/28754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd9fa5bfee38e9b46f94708f5b4d88240261b404
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to