Martin Peřina has posted comments on this change. Change subject: core: replace regexp validation for user email. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28742/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java: Line 150: */ Line 151: protected static boolean isEmailValid(String email) { Line 152: boolean valid = false; Line 153: try { Line 154: if (email == null){ > by throwing an exception all the code returning false goes Well, I don't see the benefit of throwing exception in this case. But if others will agree with exception, I will adapt. Line 155: throw new AddressException(); Line 156: } Line 157: new InternetAddress(email, true); Line 158: valid = true; -- To view, visit http://gerrit.ovirt.org/28742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18904a669453baef632af1cd427b61852e7ab583 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
