Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: remove dependency loop in setup ......................................................................
Patch Set 2: Code-Review+1 Note that if you carefully read buildSequence you see that this in itself does not cause a loop. We have the same bug in Reports - plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py:_validation has after=(oreportscons.Stages.DB_CREDENTIALS_AVAILABLE) which is from MISC. The only reason I noticed is because it broke my draft replacement for buildSequence, and then I replaced the code checking for this to just emit a warning. -- To view, visit http://gerrit.ovirt.org/28711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd0956e6fb7eea724624b85689bcd2b9dbe8bb8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
