Kobi Ianko has posted comments on this change. Change subject: Adding support in CPU monitoring ......................................................................
Patch Set 2: -Verified (1 comment) http://gerrit.ovirt.org/#/c/28815/2/mom/HypervisorInterfaces/libvirtInterface.py File mom/HypervisorInterfaces/libvirtInterface.py: Line 248: ret = {} Line 249: domain = self._getDomainFromUUID(uuid) Line 250: Line 251: # Get the user selection for vcpuLimit from the metadata Line 252: metadataCpuLimit = domain.getMetadata(2,'http://ovirt.org/param/vcpu_limit',0) > Didn't we change the url? yeah we did, in the vdsm interface, I'll need to change it here also. this section needs to support the new hierarchy in metadata that was done in the vdsm. is there a manual to how to start mom with libvirt interface, cause just changing the mom.conf file doesn't do the trick Line 253: Line 254: if metadataCpuLimit: Line 255: ret['vcpu_user_limit'] = metadataCpuLimit Line 256: else: -- To view, visit http://gerrit.ovirt.org/28815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66aa9723d3cfc6fc1c1d36a3bf42086abd010f26 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
