Juan Hernandez has posted comments on this change. Change subject: restapi: rest support for MacPool ......................................................................
Patch Set 3: (9 comments) http://gerrit.ovirt.org/#/c/28706/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-06-13 13:02:59 +0200 Line 4: Commit: Martin Mucha <[email protected]> Line 5: CommitDate: 2014-06-17 11:20:50 +0200 Line 6: Line 7: restapi: rest support for MacPool Can you include here a short description of the feature? And an example of how the generated XML description of a pool and of a data center using it? Line 8: Line 9: Change-Id: Id343433198dadd209933b69012303c51acb4c1e1 Line 10: Bug-Url: https://bugzilla.redhat.com/1078844 http://gerrit.ovirt.org/#/c/28706/3/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/restapi/resource/MacPoolResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/restapi/resource/MacPoolResource.java: Line 11: @Override Line 12: MacPool get(); Line 13: Line 14: @Override Line 15: MacPool update(MacPool resource); These two methods are already defined in UpdatableResource, no need to repeat them here. Line 16: http://gerrit.ovirt.org/#/c/28706/3/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1228: <!-- Mac Pools--> Line 1229: <xs:element name="mac_pool" type="MacPool"/> Line 1230: <xs:element name="mac_pools" type="MacPools"/> Line 1231: Line 1232: <xs:complexType name="MacPool"> Two spaces per indentation level, please. Line 1233: <xs:complexContent> Line 1234: <xs:extension base="BaseResource"> Line 1235: <xs:sequence> Line 1236: <xs:element name="shared" type="xs:boolean"/> Line 1232: <xs:complexType name="MacPool"> Line 1233: <xs:complexContent> Line 1234: <xs:extension base="BaseResource"> Line 1235: <xs:sequence> Line 1236: <xs:element name="shared" type="xs:boolean"/> Be explicit with minOccurs and maxOccurs, not only here, but everywhere. Line 1237: <xs:element name="allow_duplicates" type="xs:boolean" minOccurs="1"/> Line 1238: <xs:element name="default_pool" type="xs:boolean" minOccurs="0"/> Line 1239: <xs:element name="ranges"> Line 1240: <xs:complexType> Line 1234: <xs:extension base="BaseResource"> Line 1235: <xs:sequence> Line 1236: <xs:element name="shared" type="xs:boolean"/> Line 1237: <xs:element name="allow_duplicates" type="xs:boolean" minOccurs="1"/> Line 1238: <xs:element name="default_pool" type="xs:boolean" minOccurs="0"/> Can this be just "default"? Line 1239: <xs:element name="ranges"> Line 1240: <xs:complexType> Line 1241: <xs:sequence> Line 1242: <xs:element name="range" maxOccurs="unbounded"> Line 1236: <xs:element name="shared" type="xs:boolean"/> Line 1237: <xs:element name="allow_duplicates" type="xs:boolean" minOccurs="1"/> Line 1238: <xs:element name="default_pool" type="xs:boolean" minOccurs="0"/> Line 1239: <xs:element name="ranges"> Line 1240: <xs:complexType> Don't use this inner complex type, the SDK generators won't understand it. Line 1241: <xs:sequence> Line 1242: <xs:element name="range" maxOccurs="unbounded"> Line 1243: <xs:complexType> Line 1244: <xs:sequence> Line 1271: </xs:complexContent> Line 1272: </xs:complexType> Line 1273: Line 1274: <xs:simpleType name="MacAddress"> Line 1275: <xs:restriction base="xs:string"> Don't use "restriction", the SDK generators won't understand it. Line 1276: <xs:pattern value="[0-9a-fA-F]{2}:[0-9a-fA-F]{2}:[0-9a-fA-F]{2}:[0-9a-fA-F]{2}:[0-9a-fA-F]{2}:[0-9a-fA-F]{2}"/> Line 1277: </xs:restriction> Line 1278: </xs:simpleType> Line 1279: http://gerrit.ovirt.org/#/c/28706/3/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1926: macpool.comment: xs:string Line 1927: macpool.shared: xs:boolean Line 1928: macpool.allow_duplicates: xs:boolean Line 1929: macpool.default_pool: xs:boolean Line 1930: macpool.ranges: Use --COLLECTION. Line 1931: - range: Line 1932: from: xs:string Line 1933: to: xs:string Line 1934: comment: xs:string Line 1943: parameterType: MacPool Line 1944: signatures: Line 1945: - mandatoryArguments: Line 1946: macpool.name: xs:string Line 1947: macpool.ranges: Use --COLLECTION. Line 1948: - range: Line 1949: from: xs:string Line 1950: to: xs:string Line 1951: comment: xs:string -- To view, visit http://gerrit.ovirt.org/28706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id343433198dadd209933b69012303c51acb4c1e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
