Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: ensure restarted services survive reboot
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28235/3/packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py
File 
packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py:

Line 92:         ),
Line 93:     )
Line 94:     def _closeup(self):
Line 95:         """
Line 96:         Ensure that services we stopped while upgrading or cleaning are
I think that "or cleaning" should be removed at this point.
Line 97:         restarted and they will start at reboot.
Line 98:         """
Line 99:         for service in self._toStart:
Line 100:             if self.services.exists(service):


-- 
To view, visit http://gerrit.ovirt.org/28235
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2333590beb9f4cabcc7eb68cbbacac85b453318d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to