Daniel Erez has posted comments on this change. Change subject: webadmin: import domain - hide activate on none DC ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28855/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java: Line 33: { Line 34: super.updateItemsAvailability(); Line 35: Line 36: StoragePool dataCenter = getModel().getDataCenter().getSelectedItem(); Line 37: updateAvailabilitByDatacenter(dataCenter); > Perhaps we can remove the setIsAvailable from the initialize() method if it Done Line 38: Line 39: for (IStorageModel item : Linq.<IStorageModel> cast(getModel().getItems())) Line 40: { Line 41: if (item.getRole() == StorageDomainType.ISO) Line 79: if (datacenter == null) { Line 80: return; Line 81: } Line 82: Line 83: getModel().getActivateDomain().setIsAvailable(datacenter.getId() != StorageModel.UnassignedDataCenterId); > Use .equals instead, it's two objects Done Line 84: } Line 85: Line 86: public void postUpdateItemsAvailability(IStorageModel item, boolean isNoStorageAttached) Line 87: { -- To view, visit http://gerrit.ovirt.org/28855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d26cf3487e28dcb3319784d0f74cf589f072ec8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
