Alona Kaplan has uploaded a new change for review.

Change subject: webadmin: Interface dialog- when opening the labels scroll 
should be down
......................................................................

webadmin: Interface dialog- when opening the labels scroll should be down

when opening the network labels window, the scrollbar should be down,
so you should be able to click on '+' button without using scrollbar.

Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a
Bug-Url: https://bugzilla.redhat.com/1091695
Signed-off-by: Alona Kaplan <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/28884/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java
index d59179c..0e7b629 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java
@@ -8,6 +8,8 @@
 
 import com.google.gwt.core.shared.GWT;
 import com.google.gwt.uibinder.client.UiBinder;
+import com.google.gwt.uibinder.client.UiField;
+import com.google.gwt.user.client.ui.ScrollPanel;
 import com.google.gwt.user.client.ui.Widget;
 
 public class NicLabelWidget extends AddRemoveRowWidget<NicLabelModel, 
ListModel<String>, NicLabelEditor> {
@@ -16,6 +18,9 @@
         WidgetUiBinder uiBinder = GWT.create(WidgetUiBinder.class);
     }
 
+    @UiField
+    public ScrollPanel scrollPanel;
+
     private Collection<String> suggestions;
 
     public NicLabelWidget() {
@@ -23,6 +28,12 @@
     }
 
     @Override
+    protected void onLoad() {
+        super.onLoad();
+        scrollPanel.scrollToBottom();
+    }
+
+    @Override
     protected NicLabelEditor createWidget(ListModel<String> value) {
         NicLabelEditor widget = new NicLabelEditor();
         widget.edit(value);
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
index 6425611..3acc82d 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml
@@ -28,7 +28,7 @@
 
     <g:FlowPanel addStyleNames="{style.mainPanel} nlw_mainPanel_pfly_fix" >
         <g:Label text="{constants.labelsHostPopup}" 
addStyleNames="{style.labelStyle}" />
-        <g:ScrollPanel height="110px">
+        <g:ScrollPanel ui:field="scrollPanel" height="110px">
             <g:FlowPanel ui:field="contentPanel" />
         </g:ScrollPanel>
     </g:FlowPanel>


-- 
To view, visit http://gerrit.ovirt.org/28884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a2d5bd7280ef98a6ac0e94c336fcc6f30666c8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to