Ori Liel has posted comments on this change. Change subject: restapi: add scheduling policy elements to rsdl_metadata.yaml ......................................................................
Patch Set 5: (6 comments) Found some issues, please fix and also go over the existing stuff again carefully. http://gerrit.ovirt.org/#/c/28877/5/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 5352: case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 5353: max: {context: matrix, type: 'xs:int', value: 'max results', required: false} Line 5354: headers: Line 5355: Filter: {value: true|false, required: false} Line 5356: - name: /schedulingpolicies/{schedulingpolicy:id}/filters|rel=delete missing /{filter:id} Line 5357: description: delete a filter from specified user defined scheduling policy Line 5358: request: Line 5359: body: Line 5360: required: false Line 5366: async: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 5367: headers: Line 5368: Content-Type: {value: application/xml|json, required: true} Line 5369: Correlation-Id: {value: 'any string', required: false} Line 5370: - name: /schedulingpolicies/{schedulingpolicy:id}|rel=add should be /schedulingpolicies|rel=add Line 5371: description: add a filter to a specified user defined scheduling policy Line 5372: request: Line 5373: body: Line 5374: parameterType: Filter Line 5403: case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 5404: max: {context: matrix, type: 'xs:int', value: 'max results', required: false} Line 5405: headers: Line 5406: Filter: {value: true|false, required: false} Line 5407: - name: /schedulingpolicies/{schedulingpolicy:id}/weights|rel=delete missing /{weight:id} Line 5408: description: delete a weight from specified user defined scheduling policy Line 5409: request: Line 5410: body: Line 5411: required: false Line 5417: async: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 5418: headers: Line 5419: Content-Type: {value: application/xml|json, required: true} Line 5420: Correlation-Id: {value: 'any string', required: false} Line 5421: - name: /schedulingpolicies/{schedulingpolicy:id}|rel=add Duplicate signature, you already wrote it above. Please delete. Line 5422: description: add a weight to a specified user defined scheduling policy Line 5423: request: Line 5424: body: Line 5425: parameterType: Weight Line 5454: case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 5455: max: {context: matrix, type: 'xs:int', value: 'max results', required: false} Line 5456: headers: Line 5457: Filter: {value: true|false, required: false} Line 5458: - name: /schedulingpolicies/{schedulingpolicy:id}/balances|rel=delete missing /{balance:id} Line 5459: description: delete a balance module from specified user defined scheduling policy Line 5460: request: Line 5461: body: Line 5462: required: false Line 5468: async: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 5469: headers: Line 5470: Content-Type: {value: application/xml|json, required: true} Line 5471: Correlation-Id: {value: 'any string', required: false} Line 5472: - name: /schedulingpolicies/{schedulingpolicy:id}|rel=add Again, duplicate. From the context I understand that it's a copy-paste gone wrong, and that you meant to put a URL here that includes /balances... Line 5473: description: add a balance module to a specified user defined scheduling policy Line 5474: request: Line 5475: body: Line 5476: parameterType: Balance -- To view, visit http://gerrit.ovirt.org/28877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36f5efe9f82c914e0dec80572b2500e6839e5f7b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
