Allon Mureinik has posted comments on this change. Change subject: core: deprecate old storage allocation checks. ......................................................................
Patch Set 1: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/28897/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java: Line 63: Line 64: /** Line 65: * @deprecated Line 66: * This validation is replaced by hadSpaceForClonedDisks,hadSpaceForClonedDisk, HasSpaceForNewDisks and Line 67: * HasSpaceForNewDisk, according to the situation. All the methods should be listed in lowerCaseCamelCase Line 68: */ Line 69: @Deprecated Line 70: public ValidationResult isDomainHasSpaceForRequest(final long requestedSize) { Line 71: return isDomainHasSpaceForRequest(requestedSize, true); Line 73: Line 74: /** Line 75: * @deprecated Line 76: * This validation is replaced by hadSpaceForClonedDisks,hadSpaceForClonedDisk, HasSpaceForNewDisks and Line 77: * HasSpaceForNewDisk, according to the situation. All the methods should be listed in lowerCaseCamelCase Line 78: */ Line 79: @Deprecated Line 80: public ValidationResult isDomainHasSpaceForRequest(final long requestedSize, final boolean useThresHold) { Line 81: long size = useThresHold ? getLowDiskSpaceThreshold() : 0L; Line 172: Line 173: /** Line 174: * @deprecated Line 175: * This validation is replaced by hadSpaceForClonedDisks,hadSpaceForClonedDisk, HasSpaceForNewDisks and Line 176: * HasSpaceForNewDisk, according to the situation. All the methods should be listed in lowerCaseCamelCase Line 177: */ Line 178: @Deprecated Line 179: public static Map<StorageDomain, Integer> getSpaceRequirementsForStorageDomains(Collection<DiskImage> images, Line 180: Map<Guid, StorageDomain> storageDomains, Map<Guid, DiskImage> imageToDestinationDomainMap) { Line 192: Line 193: /** Line 194: * @deprecated Line 195: * This validation is replaced by hadSpaceForClonedDisks,hadSpaceForClonedDisk, HasSpaceForNewDisks and Line 196: * HasSpaceForNewDisk, according to the situation. All the methods should be listed in lowerCaseCamelCase Line 197: */ Line 198: @Deprecated Line 199: public static Map<StorageDomain, Integer> getSpaceRequirementsForStorageDomains(Map<DiskImage, StorageDomain> imageToDomainMap) { Line 200: Map<StorageDomain, Integer> map = new HashMap<StorageDomain, Integer>(); -- To view, visit http://gerrit.ovirt.org/28897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1fc08b4375eaea0e99593938adac48c5e2d9387 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
