Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: setup: validate jboss after yum upgrade
......................................................................

packaging: setup: validate jboss after yum upgrade

jboss may be updated while upgrading ovirt-engine,
so jboss home should be checked only after upgrade.

Change-Id: Ifbfde5a28ef8d2c3ed421ffe4d9b733ae5abe1be
Bug-Url: https://bugzilla.redhat.com/1106392
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
1 file changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/28907/1

diff --git 
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
index 9563441..0727111 100644
--- 
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
+++ 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
@@ -1,6 +1,6 @@
 #
 # ovirt-engine-setup -- ovirt engine setup
-# Copyright (C) 2013 Red Hat, Inc.
+# Copyright (C) 2013-2014 Red Hat, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -49,9 +49,16 @@
         )
 
     @plugin.event(
-        stage=plugin.Stages.STAGE_VALIDATION,
+        stage=plugin.Stages.STAGE_MISC,
+        priority=plugin.Stages.PRIORITY_FIRST,
     )
-    def _validation(self):
+    def _jboss(self):
+        """
+        Check JBOSS_HOME after ovirt-engine upgrade since jboss may be
+        upgraded as well and JBOSS_HOME may become invalid.
+        This can't be done at package stage since yum transaction is committed
+        as last action in that stage.
+        """
         if not os.path.exists(
             self.environment[
                 oengcommcons.ConfigEnv.JBOSS_HOME


-- 
To view, visit http://gerrit.ovirt.org/28907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbfde5a28ef8d2c3ed421ffe4d9b733ae5abe1be
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to