Mike Kolesnik has posted comments on this change. Change subject: core:Fix remove disk for snapshot ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java Line 215 How is this related? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java Line 102: .getAllSnapshotsForVmSnapshot(getParameters().getDstSnapshotId()); This query will retrieve all images of the snapshot. If disk was deleted together with it's history, then it images would have been deleted also. In this case, that disk's image for this snapshot would not return in this list. Therefore, I don't understand how the proposed fix is related to this behavior, unless this behavior itself changed, and this is probably the bug that should be fixed. -- To view, visit http://gerrit.ovirt.org/5579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f0f117be6616bf17f49e4234638fa833d0c8b03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
