Allon Mureinik has posted comments on this change. Change subject: core: intrdoucing host immediate domain recovery mechanism ......................................................................
Patch Set 2: (1 comment) Liron - +1 on the logic - please fix the iniline comments. Oved - We need someone from your team to review this too, please. http://gerrit.ovirt.org/#/c/27523/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 1296: List<Guid> domainsUnreachableByHost = new LinkedList<>(); Line 1297: for (Map.Entry<Guid, DomainMonitoringResult> entry : domainsInProblem.entrySet()) { Line 1298: Guid domainId = entry.getKey(); Line 1299: DomainMonitoringResult domainMonitoringResult = entry.getValue(); Line 1300: HashSet<Guid> hostsReportedDomainAsProblematic = _domainsInProblem.get(domainId); can we get less confusing names than [domainsInProblem,_domainsInProblem] Line 1301: boolean domainNotFound = domainMonitoringResult == DomainMonitoringResult.STORAGE_ACCCESS_ERROR; Line 1302: if (domainNotFound) { Line 1303: domainsUnreachableByHost.add(domainId); Line 1304: } -- To view, visit http://gerrit.ovirt.org/27523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb7b2fe8c87805986aaf25cd0f24f605d67d4186 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
