Sahina Bose has posted comments on this change. Change subject: engine: Do not access storage domain for gluster only hosts ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/28434/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java: Line 178: .addValue("storage_pool_id", storagePool) Line 179: .addValue("status", status.getValue())); Line 180: } Line 181: Line 182: > This file can be excluded Done Line 183: @Override Line 184: public List<VDS> getListForSpmSelection(Guid storagePoolId) { Line 185: return getCallsHandler().executeReadList("GetUpAndPrioritizedVds", Line 186: VdsRowMapper.instance, http://gerrit.ovirt.org/#/c/28434/3/packaging/dbscripts/vds_sp.sql File packaging/dbscripts/vds_sp.sql: Line 885: AS $procedure$ Line 886: BEGIN Line 887: BEGIN Line 888: RETURN QUERY SELECT vds.* Line 889: FROM vds, vds_groups vdsgroup > Please use the JOIN syntax instead of oldscale implicit joins. Done Line 890: WHERE (status = v_status) AND (vds.storage_pool_id = v_storage_pool_id) Line 891: AND vds.vds_group_id = vdsgroup.vds_group_id AND vdsgroup.virt_service = true; Line 892: END; Line 893: RETURN; Line 886: BEGIN Line 887: BEGIN Line 888: RETURN QUERY SELECT vds.* Line 889: FROM vds, vds_groups vdsgroup Line 890: WHERE (status = v_status) AND (vds.storage_pool_id = v_storage_pool_id) > yup. Done Line 891: AND vds.vds_group_id = vdsgroup.vds_group_id AND vdsgroup.virt_service = true; Line 892: END; Line 893: RETURN; Line 894: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/28434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6e9c02bf68146975987c6cb48cccf5c198a2e5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
