Vinzenz Feenstra has posted comments on this change. Change subject: Add OS info reporting ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28938/3/ovirt-guest-agent/GuestAgentLinux2.py File ovirt-guest-agent/GuestAgentLinux2.py: Line 231: 'type': 'linux', Line 232: 'kernel': ''} Line 233: try: Line 234: p = subprocess.Popen(cmd, stdout=subprocess.PIPE) Line 235: for line in p.stdout.read().split('\n'): > I'm wondering if subprocess.check_output may be simpler/safer here "New in version 2.7." We have to support 2.4 Line 236: k, v = line.split('=', 1) Line 237: if v and k in result: Line 238: result[k] = v Line 239: p.close() -- To view, visit http://gerrit.ovirt.org/28938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I682fd9683cf9e4b392ecd4824e4a9526bf7e5e59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
