Idan Shaby has uploaded a new change for review. Change subject: core: Replaced message of GetIsoListError ......................................................................
core: Replaced message of GetIsoListError Changed the error IRS_REPOSITORY_NOT_FOUND to GetIsoListError in GetImagesListQueryBase, and added an informative message to GetIsoListError. Change-Id: I4199a18f62902c0402f190f83f1878d507b238b2 Bug-Url: https://bugzilla.redhat.com/918949 Signed-off-by: Idan Shaby <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/29032/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java index 13a2b39..6c5daf8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java @@ -20,7 +20,7 @@ getQueryReturnValue().setReturnValue(getUserRequestForStorageDomainRepoFileList()); if (getQueryReturnValue().getReturnValue() == null) { getQueryReturnValue().setSucceeded(false); - getQueryReturnValue().setExceptionString(VdcBllErrors.IRS_REPOSITORY_NOT_FOUND.toString()); + getQueryReturnValue().setExceptionString(VdcBllErrors.GetIsoListError.toString()); } } diff --git a/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties b/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties index c9fb1eb..98e1460 100644 --- a/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties +++ b/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties @@ -134,7 +134,7 @@ GetAllLogicalVolumeTagsError=Cannot get tags of all Logical Volumes of Volume Group GetFloppyListError=Cannot get floppy list GetiSCSISessionListError=Get iSCSI session list error -GetIsoListError=Cannot get ISO list +GetIsoListError=Cannot get list of images in ISO domain. Please check that the storage domain status is Active. GetLogicalVolumeDevError=Cannot get physical devices of logical volume GetLogicalVolumesByTagError=Cannot get Logical Volumes with specific tag GetLogicalVolumeTagError=Cannot get tags of Logical Volumes diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties index 3f74ab5..74b4ba7 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties @@ -129,7 +129,7 @@ GetAllLogicalVolumeTagsError=Cannot get tags of all Logical Volumes of Volume Group GetFloppyListError=Cannot get floppy list GetiSCSISessionListError=Get iSCSI session list error -GetIsoListError=Cannot get ISO list +GetIsoListError=Cannot get list of images in ISO domain. Please check that the storage domain status is Active. GetLogicalVolumeDevError=Cannot get physical devices of logical volume GetLogicalVolumesByTagError=Cannot get Logical Volumes with specific tag GetLogicalVolumeTagError=Cannot get tags of Logical Volumes diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties index aac0f20..3e6a529 100644 --- a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties +++ b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties @@ -129,7 +129,7 @@ GetAllLogicalVolumeTagsError=Cannot get tags of all Logical Volumes of Volume Group GetFloppyListError=Cannot get floppy list GetiSCSISessionListError=Get iSCSI session list error -GetIsoListError=Cannot get ISO list +GetIsoListError=Cannot get list of images in ISO domain. Please check that the storage domain status is Active. GetLogicalVolumeDevError=Cannot get physical devices of logical volume GetLogicalVolumesByTagError=Cannot get Logical Volumes with specific tag GetLogicalVolumeTagError=Cannot get tags of Logical Volumes -- To view, visit http://gerrit.ovirt.org/29032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4199a18f62902c0402f190f83f1878d507b238b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
