Gilad Chaplik has posted comments on this change. Change subject: webadmin: add buttons in the new cluster dialog and make it closeable ......................................................................
Patch Set 2: Code-Review-1 (2 comments) See inline. http://gerrit.ovirt.org/#/c/28380/2//COMMIT_MSG Commit Message: Line 15: The codes that add buttons in the dialog were inside a Line 16: async-callback method.(This callback method is used to Line 17: set the data center list of the dialog after query from Line 18: the database.) This is unreasonable. The codes should be Line 19: outside the callback method.This patch fixed the problem. the code shouldn't be there, because we want to ensure all the data is in-place before we allow submitting the form (=OK button). Line 20: Line 21: Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Line 22: Bug-Url: https://bugzilla.redhat.com/1079180 http://gerrit.ovirt.org/#/c/28380/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 325: { Line 326: StoragePool selectDataCenter = (StoragePool) clModel.getSystemTreeSelectedItem().getEntity(); Line 327: Line 328: cModel.getDataCenter().setSelectedItem(Linq.firstOrDefault(dataCenters, Line 329: new Linq.DataCenterPredicate(selectDataCenter.getId()))); probably a NPE exception is thrown here. Line 330: cModel.getDataCenter().setIsChangable(false); Line 331: } Line 332: else Line 333: { -- To view, visit http://gerrit.ovirt.org/28380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33802bc7d3a703e6b15b7674a8255a50cf34e4f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Malike <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
