Kobi Ianko has posted comments on this change. Change subject: db: Adding Cpu Qos DB config ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27686/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java: Line 23: Line 24: public void setCpuLimit(Integer cpuLimit) { Line 25: this.cpuLimit = cpuLimit; Line 26: } Line 27: > IINM, should be in former patch Done Line 28: @Override Line 29: public int valuesHashCode() { Line 30: final int prime = 31; Line 31: int result = super.hashCode(); http://gerrit.ovirt.org/#/c/27686/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 177: put(VnicProfile.class, VnicProfileDao.class); Line 178: put(VnicProfileView.class, VnicProfileDao.class); Line 179: put(DwhHistoryTimekeeping.class, DwhHistoryTimekeepingDao.class); Line 180: put(IscsiBond.class, IscsiBondDao.class); Line 181: put(VmInit.class, VmInitDAO.class); > probably should be added here for the sake of RemoveStoragePoolCommand tran Done Line 182: } Line 183: }; Line 184: Line 185: private JdbcTemplate jdbcTemplate; -- To view, visit http://gerrit.ovirt.org/27686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I533bcc601ac44289c51f5d56a6da0dd2455116d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
