Allon Mureinik has posted comments on this change. Change subject: core: AddLSM source sd allocation validation ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28961/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java: Line 420: Map<Guid, List<DiskImage>> storageDomainsActiveImagesMap = new HashMap<>(); Line 421: Line 422: for (LiveMigrateDiskParameters parameters : getParameters().getParametersList()) { Line 423: DiskImage diskImage = getDiskImageByImageId(parameters.getImageId()); Line 424: if (diskImage.getActive()) { why? Line 425: MultiValueMapUtils.addToMap(parameters.getSourceStorageDomainId(), Line 426: diskImage, Line 427: storageDomainsActiveImagesMap); Line 428: continue; -- To view, visit http://gerrit.ovirt.org/28961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1914f5efe50d2f5a4fb9debf0c0bde4ffc9e32eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
