Yaniv Bronhaim has posted comments on this change.

Change subject: ui: Enhance to multi line list box for discovered hosts info
......................................................................


Patch Set 1:

(1 comment)

do the findbugs error relate to me ?

http://gerrit.ovirt.org/#/c/29124/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java:

Line 35: 
Line 36:     public String getDescription() {
Line 37:         return "MAC: " + mac + "\n" +
Line 38:                " | DiscoverTime : " + lastReport + "\n" +
Line 39:                " | Subnet: " + subnetName;
> what other fields are available for us here?
that's all - 
 
[{"name":"mac5254008638f0","id":112,"ip":"192.168.223.226","mac":"52:54:00:86:38:f0","last_report":"2014-06-24T08:23:27Z","subnet_id":1,"subnet_name":"example.com"}]
Line 40:     }


-- 
To view, visit http://gerrit.ovirt.org/29124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to