Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup - Don't use httpd proxy when ipa
installed
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 857: return False
This is shorter:
return rc == 0
Line 859: def setHttpPortsToJbossDefault(controller):
Eventually we will fix bug 831193, and then the ports will not be "jboss"
ports, but "engine" ports. I would suggest to name this function
"setHttpPortsToEngineDefault".
Line 860: logging.debug("Changing HTTP_PORT & HTTPS_PORT to the default
jboss values (8080 & 8443)")
Same for this message, engine instead of jboss.
--
To view, visit http://gerrit.ovirt.org/5635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb1f9cd7ad298fd785383f7ba4e447b4296d230
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
