Ramesh N has posted comments on this change. Change subject: gluster: update task details in stop remove brick ......................................................................
Patch Set 5: (1 comment) Patch set to follow http://gerrit.ovirt.org/#/c/24319/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java: Line 73: GlusterTaskUtils.getInstance().getSummaryMessage(rebalanceStatusEntity.getStatusSummary())), Line 74: GlusterTaskUtils.getInstance().isTaskSuccess(stepStatus)); Line 75: Line 76: } else { Line 77: endStepJob(JobExecutionStatus.ABORTED, getStepMessageMap(JobExecutionStatus.ABORTED, " "), false); > cant you change this to null as well? Sorry. I missed here. I have changed it to null. Line 78: } Line 79: releaseVolumeLock(); Line 80: setSucceeded(vdsReturnaValue.getSucceeded()); Line 81: getReturnValue().setActionReturnValue(rebalanceStatusEntity); -- To view, visit http://gerrit.ovirt.org/24319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90be6a98470f0cb72bc7508f2cb2364f77e02077 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
