Alon Bar-Lev has posted comments on this change. Change subject: kdump: Check for crashkernel param ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29183/2/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 111: _( Line 112: 'Kernel command line parameter crashkernel is not ' Line 113: 'specified, kdump detection is not supported' Line 114: ) Line 115: ) hmmm.... now everyone will see this warning? it is not actual warning... people that do not have kdump do not want kdump... we can add info at the end of the entire detection stage, something like: kdump fence supported or: kdump fence unsupported Line 116: return crashkernel Line 117: Line 118: def _update_kdump_conf( Line 119: self, -- To view, visit http://gerrit.ovirt.org/29183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83efd12c8763f2336506fa61c34c38d7fc9bfe8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
