Allon Mureinik has posted comments on this change. Change subject: core: List VMs with filtering enabled only by user roles. (#783087) ......................................................................
Patch Set 2: I would prefer that you didn't submit this Please add the "AND role_type = 2" in the WHERE clause, and not as part of the JOIN statement for readability. Also, please update the commit message - this patch is no longer strictly about VMs. -- To view, visit http://gerrit.ovirt.org/5592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bc504dbbebbf202e456669686cb905b2b7a9a3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
