Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Fix getFriendlyVersion ......................................................................
webadmin: Fix getFriendlyVersion getFriendlyVersion should return 3.1 for vdsm version 4.10. Most of the usages of getFriendlyVersion compare the result with the minimum compatibility version (check that it is equal or greater than the mimimum compatbility version for a feature) Prior to this patch, 4.10 would have resulted as version 4.10 so the comparsion would have returned a value greater than 0, now the Version returned from getFriendlyVersion will be 3.1 (as for 4.9 it returned 3.0). So the comparsion would also return a value greater than 0 (So no regression here). The only change is that at UI for host you will see vdsm version 3.1.x.y instead of 4.10.x.y This is an interim patch until we start working with RpmVersion and then we should revisit this. Change-Id: I88e55c73d4b7747d8af8dcda5e112694aeea3030 Acked-By: Signed-off-by: Yair Zaslavsky <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Extensions.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e55c73d4b7747d8af8dcda5e112694aeea3030 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
