Alona Kaplan has posted comments on this change. Change subject: webadmin: AddRemoveRowWidget to enable/disable rows ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/29228/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java: Line 185: becomingGhost what about the enabled? http://gerrit.ovirt.org/#/c/29228/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java: Line 82: Why was the 'enabled' removed from here? Line 83: same Line 84: I saw this code was moved to AddRemoveRowWidget.addEntry(), but as I wrote there, two line after it is ovveridden. Smells like a bug... -- To view, visit http://gerrit.ovirt.org/29228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a6265b5c0eb27c3b99b98d88986762249acdbe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
