Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: binding file groups and product options ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/29206/8/packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py File packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py: Line 228: if product_option in self.environment[ Line 229: osetupcons.RemoveEnv.REMOVE_OPTIONS Line 230: ]: Line 231: if not optional: Line 232: add_group = True > mmm.... What happens if product_option is None and optional is False? If osetupcons.RemoveEnv.REMOVE_ALL is True everything gets removed as it was before. Otherwise in that case it doesn't remove the group and on my opinion is the safer behavior: I'm removing just a product option and I find a file group that I'm not sure is really relative to one of the product options I'm going to remove, I keep the file group otherwise I'll risk to remove file groups of other product options. Line 233: elif ( Line 234: interactive and Line 235: group not in already_asked Line 236: ): -- To view, visit http://gerrit.ovirt.org/29206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad7cd9d8196da89e5c4800aa1263467853f136f8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
