Yair Zaslavsky has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 2: Alon, I understand your claim. The question is - would we want in your opinion to add more attributes like that? I will try to explain. If you look at the flow of commands until the point a query is executed, you might need the execution context, the lock, the compensation context. These are not required for queries. it's good they are not in EngineContext. correlationId and sessionId are shared across the flows of engine from "top to bottom" - so I think that for parts of the flow (for example - > from Command to Query) if we need more variables we can add them on the relevant class (CommandBase, QueriesCommandBase, etc..) I think you also realize that "detach" sounds too vague , right? I'm not locked on my suggestion, trying to find the best name :) -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
