Ofer Schreiber has posted comments on this change. Change subject: packaging: Moving Jboss configuration functions to separate module ......................................................................
Patch Set 6: (3 inline comments) .................................................... File packaging/fedora/setup/jboss_utils.py Line 11: masked_value_set = set() Where we use it? Line 13: def initJbossUtils(controllerObj, masked_value_set_Obj): Any chance to avoid this? Maybe caller functions in engine-setup, which will call jboss_utils functions with right params? Line 19: def encryptDBPass(): Sounds unrelated to JBoss, more a part of common_utils -- To view, visit http://gerrit.ovirt.org/4841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68c069591d04234efb1ccd551a9cff2f7d5ba8a1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
