Allon Mureinik has submitted this change and it was merged. Change subject: core: Throwing exception instead of handle fault ......................................................................
core: Throwing exception instead of handle fault CommandBase -> executeWithoutTransaction already handles a VdcBLLException by calling processExceptionToClient. So AddStorageServerConnectionCommand should throw an exception with a right error message, and this way both UI and REST api get the same response. Change-Id: I3e6b8282d9e2cdd6e17f21a2ef034041d68d09fc Bug-Url: https://bugzilla.redhat.com/1108164 Signed-off-by: Idan Shaby <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java 1 file changed, 7 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/29259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e6b8282d9e2cdd6e17f21a2ef034041d68d09fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
