Alon Bar-Lev has posted comments on this change. Change subject: kdump: Check for crashkernel param ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29183/4/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 182: result=( Line 183: 'supported' Line 184: if self.environment[odeploycons.KdumpEnv.SUPPORTED] Line 185: else 'unsupported' Line 186: ), > Alon, why did you change the message during rebase of PS3 to PS4 from it is unsupported if not detected or disabled. user knows nothing about detection, but the bottom line. Line 187: ) Line 188: ) Line 189: Line 190: @plugin.event( -- To view, visit http://gerrit.ovirt.org/29183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie83efd12c8763f2336506fa61c34c38d7fc9bfe8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
