Yair Zaslavsky has uploaded a new change for review. Change subject: core: Change in IrsBrokerCommand.init ......................................................................
core: Change in IrsBrokerCommand.init Instead of put - we should use putIfAbsent Change-Id: If470aa1b5c6df42863c091cc394c90c340f0ac06 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/29396/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java index 984871e..9636336 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java @@ -8,6 +8,7 @@ import java.util.Map; import java.util.concurrent.Callable; import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; import org.apache.commons.lang.exception.ExceptionUtils; import org.ovirt.engine.core.common.businessentities.StorageDomainStatic; @@ -42,7 +43,7 @@ @Logged(errorLevel = LogLevel.ERROR) public abstract class IrsBrokerCommand<P extends IrsBaseVDSCommandParameters> extends BrokerCommandBase<P> { - private static Map<Guid, IrsProxyData> _irsProxyData = new ConcurrentHashMap<Guid, IrsProxyData>(); + private static ConcurrentMap<Guid, IrsProxyData> _irsProxyData = new ConcurrentHashMap<Guid, IrsProxyData>(); static final VDSStatus reportingVdsStatus = VDSStatus.Up; /** @@ -77,7 +78,7 @@ public static void init() { for (StoragePool sp : DbFacade.getInstance().getStoragePoolDao().getAll()) { if (!_irsProxyData.containsKey(sp.getId())) { - _irsProxyData.put(sp.getId(), new IrsProxyData(sp.getId())); + _irsProxyData.putIfAbsent(sp.getId(), new IrsProxyData(sp.getId())); } } } -- To view, visit http://gerrit.ovirt.org/29396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If470aa1b5c6df42863c091cc394c90c340f0ac06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
