Ayal Baron has posted comments on this change. Change subject: webadmin: Disable changing of DC when adding a new external disk (#833120) ......................................................................
Patch Set 1: (3 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java Line 735: Boolean isInVm = (Boolean) getIsInVm().getEntity(); isInVm means the disk is attached to VM or user reached here from a VM context? (i.e. inVmContext) Line 736: Boolean isInternal = (Boolean) getIsInternal().getEntity(); isInternal means it's not a LUN? Line 738: getDataCenter().setIsAvailable(!isInVm && !isInternal); Does this mean that data center field is only available for LUNs (external disks) and even then only when not in vm context? i.e. for a floating disk dataCenter would not be displayed? -- To view, visit http://gerrit.ovirt.org/5710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7da92ffbfaa265c40b9df1d55bde871d409f32a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
