Alon Bar-Lev has uploaded a new change for review. Change subject: bll: host-deploy: print correct paths in error message ......................................................................
bll: host-deploy: print correct paths in error message Change-Id: I9e494ef19083485d9c75f839df2fce884916374e Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/29439/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java index b8e1852..2cce2be 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java @@ -32,13 +32,13 @@ import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AlertDirector; import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector; import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase; +import org.ovirt.engine.core.utils.EngineLocalConfig; import org.ovirt.engine.core.utils.ThreadUtils; import org.ovirt.engine.core.utils.lock.EngineLock; import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil; public abstract class VdsCommand<T extends VdsActionParameters> extends CommandBase<T> { - private static final String GENERIC_ERROR = "Please refer to engine.log and log files under /var/log/ovirt-engine/host-deploy/ on the engine for further details."; protected String _failureMessage = null; /** @@ -283,7 +283,10 @@ } protected String getErrorMessage(String msg) { - return StringUtils.isEmpty(msg) ? GENERIC_ERROR : msg; + return !StringUtils.isEmpty(msg) ? msg : String.format( + "Please refer to %1$s/engine.log and log logs under %1$s/ovirt-engine/host-deploy/ for further details.", + EngineLocalConfig.getInstance().getLogDir() + ); } @SuppressWarnings("serial") -- To view, visit http://gerrit.ovirt.org/29439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e494ef19083485d9c75f839df2fce884916374e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
