anmolbabu has uploaded a new change for review. Change subject: gluster-nagios-monitoring : Fix for showDashboard incorrect comparison ......................................................................
gluster-nagios-monitoring : Fix for showDashboard incorrect comparison the config variable showDashboard was being treated as a boolean instead of a string.This patch corrects it. Change-Id: I4c90d8faa3140f6705fe1d6facfaefe376a832dd Signed-off-by: Anmol Babu <[email protected]> --- M gluster-nagios-monitoring/src/js/dashboard-init.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/samples-uiplugins refs/changes/43/29443/1 diff --git a/gluster-nagios-monitoring/src/js/dashboard-init.js b/gluster-nagios-monitoring/src/js/dashboard-init.js index 90797a0..624f3de 100644 --- a/gluster-nagios-monitoring/src/js/dashboard-init.js +++ b/gluster-nagios-monitoring/src/js/dashboard-init.js @@ -10,7 +10,7 @@ var tabWindow, selectedTreeItem; return { addTabs: function () { - if (pluginApi.configObject().showDashboard) { + if (pluginApi.configObject().showDashboard && pluginApi.configObject().showDashboard == "true" ) { pluginApi.addMainTab('Dashboard', 'dashboard-tab', urlUtil.relativeUrl('dashboard.html')); } pluginApi.addMainTab('Trends', 'trends-tab', urlUtil.relativeUrl('trendsTab.html')); -- To view, visit http://gerrit.ovirt.org/29443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c90d8faa3140f6705fe1d6facfaefe376a832dd Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
