Omer Frenkel has posted comments on this change. Change subject: core: WIP - Add support for Qemu GA (#830954) ......................................................................
Patch Set 2: (2 inline comments) not sure i understand why a vm device is needed .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java Line 673: VM vm = vmDao.get(id); looks like getting the vm above is not needed .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java Line 63: "vmPayload", "balloonEnabled", "qemuGaEnabled" }); i don't think this is needed, these is used for fields in vm static table -- To view, visit http://gerrit.ovirt.org/5734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59c307b49d606ebc06b84cecc4226fc94f29d97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
