Allon Mureinik has posted comments on this change. Change subject: core: when iso domain is inactive we still go to the cache ......................................................................
Patch Set 1: (1 inline comment) see inline comment regarding code reuse. Also, there are two parts to this patch - moving findActiveIsoDomain to VMHandler and the new logic - I'd separate it to two patches. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java Line 187: */ There seems to be a lot of shared code between getUserRequestForStorageDomainRepoFileList and this function (validations, etc). Can't it be reused in any way? -- To view, visit http://gerrit.ovirt.org/5184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d24c94c4dd630c5a76ae1fee65bee257b5e40f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
