Roy Golan has posted comments on this change. Change subject: core: Add engine-java script ......................................................................
Patch Set 3: (2 inline comments) generally IMHO very nice solution .................................................... File Makefile Line 367: install -m 755 packaging/fedora/engine-java.py $(PREFIX)/usr/share/ovirt-engine/scripts correct I didn't notice it. thats cool then. by the way engine-java is a really general name. I think the words "ovirt" and "wrapper/launcher" should be there instead. what do you think? because every user will now see engine-java in its path. the convention of ovirt looks better to me. .................................................... File packaging/fedora/engine-java.py Line 202: if item in files: so childeren are subdirectories in the current directory and I don't see the interation on these subdirs. I think I'll RTFM of os.walk ... :) -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
