Martin Peřina has posted comments on this change. Change subject: kdump: Rename "kdump detection" to "kdump integration" ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29479/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 178: self.environment[odeploycons.KdumpEnv.SUPPORTED] = True Line 179: break Line 180: Line 181: self.logger.info( Line 182: _('Kdump integration {result}').format( > you are making this more complex than it should. why not telling the entire The positive answer is not that valuable, but the negative one is. I disagree with you, but I give up. Line 183: result=( Line 184: 'supported' Line 185: if self.environment[odeploycons.KdumpEnv.SUPPORTED] Line 186: else 'unsupported' -- To view, visit http://gerrit.ovirt.org/29479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a3138054aef980f0971a17a62d3067156780d83 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
