Alon Bar-Lev has posted comments on this change. Change subject: webadmin: Rename "kdump detection" to "kdump integration" ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29478/1/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1043: ACTION_TYPE_FAILED_RNG_SOURCE_NOT_SUPPORTED=Cannot ${action} ${type}. Random Number Generator device is not supported in cluster. Line 1044: ACTION_TYPE_RNG_MUST_BE_SPECIFIED=Cannot ${action} ${type}. Random Number Generator must be specified in parameters. Line 1045: Line 1046: KDUMP_DETECTION_NOT_ENABLED_FOR_VDS=Cannot ${action} ${type}. Kdump integration is not enabled for host '${VdsName}'. Line 1047: KDUMP_DETECTION_NOT_CONFIGURED_ON_VDS=Cannot ${action} ${type}. Kdump integration is not properly configured on host '${VdsName}'. > Again, kdump can be configured properly even without fence_kdump options, b kdump integration is an engine feature you *CANNOT* use this term to refer to anything at host side. at host you have standard tools, please use the host terms when referring to anything at host. http://gerrit.ovirt.org/#/c/29478/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 1502: Line 1503: @DefaultStringValue("Boot Time") Line 1504: String bootTimeHostGeneral(); Line 1505: Line 1506: @DefaultStringValue("Kdump Integration") > This is label that shows status of kdump integration configuration. Even if I think this relates to my previous comment of using host terms for host. Line 1507: String kdumpStatus(); Line 1508: Line 1509: @DefaultStringValue("SELinux mode") Line 1510: String selinuxModeGeneral(); -- To view, visit http://gerrit.ovirt.org/29478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bdcf78eb27902951f0298b13bf671bebd828fc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
