Roy Golan has posted comments on this change. Change subject: restapi: Deploy using modules ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29474/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ValidatorLocator.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ValidatorLocator.java: Line 22: Line 23: import org.ovirt.engine.api.common.util.PackageExplorer; Line 24: import org.slf4j.Logger; Line 25: import org.slf4j.LoggerFactory; Line 26: using CDI this class could be really deprecated no? Line 27: public class ValidatorLocator { Line 28: /** Line 29: * The logger used by this class. Line 30: */ http://gerrit.ovirt.org/#/c/29474/1/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 126: # application server started by the engine. This is a list of space Line 127: # separated files or directories that should exist under Line 128: # /usr/share/ovirt-engine: Line 129: # Line 130: ENGINE_APPS="engine.ear restapi.war legacy_restapi.war" does that imposes order? I'm asking because the REST app obviously needs to fetch a backend instance by (currently) a JNDI lookup when loading. Line 131: ENGINE_URI=/ovirt-engine Line 132: Line 133: # Line 134: # Flags to enable or disable the web server (the proxy) and the -- To view, visit http://gerrit.ovirt.org/29474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4079277f60e5521d9b61379fa78713a5c4ccc10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
