Gilad Chaplik has posted comments on this change. Change subject: core: add disk profile to newly created storage domain ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29037/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 75: StorageDomainStatic storageStaticData = getStorageDomain().getStorageStaticData(); Line 76: DbFacade.getInstance().getStorageDomainStaticDao().save(storageStaticData); Line 77: // create default disk profile for type master or data storage domains Line 78: if (storageStaticData.getStorageDomainType() == StorageDomainType.Master Line 79: || storageStaticData.getStorageDomainType() == StorageDomainType.Data) { > Few questions: * currently for all, I don't see any issues with that. * very good point, do you have any suggestion? Line 80: getDiskProfileDao().save(DiskProfileHelper.createDiskProfile(storageStaticData.getId(), Line 81: storageStaticData.getStorageName())); Line 82: } Line 83: getCompensationContext().snapshotNewEntity(storageStaticData); -- To view, visit http://gerrit.ovirt.org/29037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
