Moti Asayag has posted comments on this change. Change subject: restapi: add network usages field to "add network to data-center" action parameters ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/29447/1/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1298: body: Line 1299: parameterType: Network Line 1300: signatures: Line 1301: - mandatoryArguments: {network.id|name: 'xs:string'} Line 1302: optionalArguments: { can't we spare the surrounding curly brackets ? here and below. Line 1303: network.description: 'xs:string', Line 1304: network.comment: 'xs:string', Line 1305: network.vlan.id: 'xs:string', Line 1306: network.ip.address: 'xs:string', Line 1305: network.vlan.id: 'xs:string', Line 1306: network.ip.address: 'xs:string', Line 1307: network.ip.gateway: 'xs:string', Line 1308: network.ip.netmask: 'xs:string', Line 1309: network.display: 'xs:boolean', the network.display is meaningless in this context. It should be asked only in the context of cluser: /clusters/{cluster:id}/networks|rel=add Line 1310: network.stp: 'xs:boolean', Line 1311: network.mtu: 'xs:int', Line 1312: network.profile_required: 'xs:boolean', Line 1313: network.usages.usage--COLLECTION: {usage: 'xs:string'} Line 3142: network.vlan.id: 'xs:string', Line 3143: network.ip.address: 'xs:string', Line 3144: network.ip.gateway: 'xs:string', Line 3145: network.ip.netmask: 'xs:string', Line 3146: network.display: 'xs:boolean', same comment as above, regarding 'display' necessity Line 3147: network.stp: 'xs:boolean', Line 3148: network.mtu: 'xs:int', Line 3149: network.profile_required: 'xs:boolean', Line 3150: network.usages.usage--COLLECTION: {usage: 'xs:string'} -- To view, visit http://gerrit.ovirt.org/29447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5549de3adee242801cd6034426ec67310cbf8d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
