Alona Kaplan has posted comments on this change. Change subject: webadmin: Add button for MAC pool creation in DC dialog ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/29230/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 360: @Override Line 361: protected void onActionSucceeded(Guid macPoolId) { Line 362: MacPool macPool = getEntity(); Line 363: macPool.setId(macPoolId); Line 364: dcModel.getMacPoolListModel().getItems().add(macPool); I"m not sure but I think that if you"ll add more than one mac pool you"ll have a bug. The list will contain just the last one. 'setItems' should be called to update the list. Line 365: dcModel.getMacPoolListModel().setSelectedItem(macPool); Line 366: DataCenterListModel.this.setConfirmWindow(null); Line 367: } Line 368: }; -- To view, visit http://gerrit.ovirt.org/29230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I585ab2d39bb5e0f88285d16e69eeae1c818391bc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
