Yaniv Dary has posted comments on this change.

Change subject: engine: move speed property from VdsNetworkInterface to 
VdsNetworkStatistics
......................................................................


Patch Set 7: Code-Review-1

Why do you want to move a slow changing value [how many times a day do you 
change interface speed??] to a table that changes every 15 seconds. It makes no 
sense and it will cause damage to the collection process to data warehouse. 
please consider another approach.

-- 
To view, visit http://gerrit.ovirt.org/28913
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4be28a786bee1eae6367c4ef19c9ee3b4afec61
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to